Add MFA support for azd #42488
Open
Add MFA support for azd #42488
+102
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
xiangyan99
requested review from
maorleger,
christothes,
scottaddie,
chlowell,
anannya03 and
minhanh-phan
There was a problem hiding this comment.
Pull Request Overview
This PR adds Multi-Factor Authentication (MFA) support for the Azure Developer CLI credential by implementing claims handling in both sync and async versions of AzureDeveloperCliCredential.
Key changes:
- Enables the
claimsparameter inget_token()methods to handle MFA challenges - Adds a new utility function to extract user-friendly error messages from azd CLI JSON output
- Improves error handling by parsing structured error messages from azd CLI output
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sdk/identity/azure-identity/azure/identity/aio/_credentials/azd_cli.py |
Async version - adds claims parameter support and improved error message extraction |
sdk/identity/azure-identity/azure/identity/_credentials/azd_cli.py |
Sync version - implements claims parameter support and adds extract_cli_error_message utility function |
Comments suppressed due to low confidence (1)
sdk/identity/azure-identity/azure/identity/_credentials/azd_cli.py:329
- Use f-string formatting instead of
.format()for consistency with the rest of the codebase. Replace withcombined_text = f"{ex.output or ''}\n{ex.stderr or ''}"
combined_text = "{}\n{}".format(ex.output or "", ex.stderr or "")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For AzdCredential, upon receiving claims during the get_token call, we need to invoke
azd auth token --claims <claims_challenge>to allow Azd to store the claims.Subsequently, we notify the user to run
azd auth loginagain to re-authenticate.